From 16884f2baf9b1c622b5c406fb4fba1c841340f23 Mon Sep 17 00:00:00 2001
From: Christopher Baines <mail@cbaines.net>
Date: Sat, 22 Jun 2024 10:33:51 +0100
Subject: Handle more error cases in package-changes-summary-table

---
 guix-qa-frontpage/view/shared.scm | 107 +++++++++++++++++++++-----------------
 1 file changed, 58 insertions(+), 49 deletions(-)

(limited to 'guix-qa-frontpage/view')

diff --git a/guix-qa-frontpage/view/shared.scm b/guix-qa-frontpage/view/shared.scm
index 708ac63..804923b 100644
--- a/guix-qa-frontpage/view/shared.scm
+++ b/guix-qa-frontpage/view/shared.scm
@@ -745,55 +745,64 @@
               (td (@ (colspan 10)
                      (class "bad"))
                   "Comparison unavailable"
-                  ,@(or (and=>
-                         (assq-ref derivation-changes-counts
-                                   'invalid_query_parameters)
-                         (lambda (params)
-                           (append-map
-                            (match-lambda
-                              ((param . details)
-                               (let ((error
-                                      (assq-ref details 'error)))
-                                 (cond
-                                  ((member param '("base_commit"
-                                                   "target_commit"))
-                                   `((br)
-                                     (a
-                                      (@ (href
-                                          ,(string-append
-                                            "https://data.qa.guix.gnu.org"
-                                            "/revision/"
-                                            (assq-ref
-                                             revisions
-                                             (if (string=? param "base_commit")
-                                                 'base
-                                                 'target)))))
-                                      ,(cond
-                                        ((eq? error 'unknown-commit)
-                                         (string-append
-                                          (if (string=? param "base_commit")
-                                              "Base revision "
-                                              "Target revision ")
-                                          "unknown to the data service."))
-                                        ((member error
-                                                 '(yet-to-process-revision
-                                                   failed-to-process-revision))
-                                         (simple-format
-                                          #f "~A to process ~A"
-                                          (if (eq? error 'yet-to-process-revision)
-                                              "Yet"
-                                              "Failed")
-                                          (if (string=? param "base_commit")
-                                              "base revision (from master branch)"
-                                              "target revision")))
-                                        (else
-                                         (string-append
-                                          "Error with "
-                                          (if (string=? param "base_commit")
-                                              "base revision."
-                                              "target revision.")))))))))))
-                            params)))
-                        '()))))))))
+                  ,@(cond
+                     ((eq? (assq-ref derivation-changes-counts 'exception)
+                           'guix-data-service-invalid-parameters)
+                      (append-map
+                       (match-lambda
+                         ((param . details)
+                          (let ((error
+                                 (assq-ref details 'error)))
+                            (cond
+                             ((member param '("base_commit"
+                                              "target_commit"))
+                              `((br)
+                                (a
+                                 (@ (href
+                                     ,(string-append
+                                       "https://data.qa.guix.gnu.org"
+                                       "/revision/"
+                                       (assq-ref
+                                        revisions
+                                        (if (string=? param "base_commit")
+                                            'base
+                                            'target)))))
+                                 ,(cond
+                                   ((eq? error 'unknown-commit)
+                                    (string-append
+                                     (if (string=? param "base_commit")
+                                         "Base revision "
+                                         "Target revision ")
+                                     "unknown to the data service."))
+                                   ((member error
+                                            '(yet-to-process-revision
+                                              failed-to-process-revision))
+                                    (simple-format
+                                     #f "~A to process ~A"
+                                     (if (eq? error 'yet-to-process-revision)
+                                         "Yet"
+                                         "Failed")
+                                     (if (string=? param "base_commit")
+                                         "base revision (from master branch)"
+                                         "target revision")))
+                                   (else
+                                    (string-append
+                                     "Error with "
+                                     (if (string=? param "base_commit")
+                                         "base revision."
+                                         "target revision.")))))))))))
+                       (assq-ref derivation-changes-counts
+                                 'invalid_query_parameters)))
+                     ((eq? (assq-ref derivation-changes-counts 'exception)
+                           'guix-data-service-exception)
+                      (let ((url
+                             (assq-ref derivation-changes-counts 'url)))
+                        `((br)
+                          "Exception fetching data from "
+                          (a (@ (href ,url))
+                             ,url))))
+                     (else
+                      '())))))))))
 
 (define (package-cross-changes-summary-table revisions
                                              cross-derivation-changes-counts
-- 
cgit v1.2.3