diff options
| author | Ludovic Courtès <ludo@gnu.org> | 2015-02-24 23:05:45 +0100 |
|---|---|---|
| committer | Ludovic Courtès <ludo@gnu.org> | 2015-02-24 23:43:03 +0100 |
| commit | 2178ed66f7ae8f793078c7e392af4bf1fb472968 (patch) | |
| tree | 91589714052eb7d3fb36ca61f538ca72a578143c /m4 | |
| parent | 43da8f018d5835b62e8f5f1f4e2cc701f828a3db (diff) | |
| download | patches-2178ed66f7ae8f793078c7e392af4bf1fb472968.tar patches-2178ed66f7ae8f793078c7e392af4bf1fb472968.tar.gz | |
build: Reject or warn against file name length limit overruns.
* m4/guix.m4 (GUIX_TEST_ROOT_DIRECTORY, LINUX_HASH_BANG_LIMIT,
SOCKET_FILE_NAME_LIMIT, GUIX_SOCKET_FILE_NAME_LENGTH,
GUIX_TEST_SOCKET_FILE_NAME_LENGTH, GUIX_HASH_BANG_LENGTH,
GUIX_CHECK_FILE_NAME_LIMITS): New macros.
* configure.ac: Use 'GUIX_CHECK_FILE_NAME_LIMITS'.
* config-daemon.ac: Use 'GUIX_TEST_ROOT_DIRECTORY'.
* test-env.in: Check socket name length and emit warning if it exceeds
107.
Diffstat (limited to 'm4')
| -rw-r--r-- | m4/guix.m4 | 58 |
1 files changed, 57 insertions, 1 deletions
diff --git a/m4/guix.m4 b/m4/guix.m4 index d4415598b0..445ce857dd 100644 --- a/m4/guix.m4 +++ b/m4/guix.m4 @@ -1,5 +1,5 @@ dnl GNU Guix --- Functional package management for GNU -dnl Copyright © 2012, 2013, 2014 Ludovic Courtès <ludo@gnu.org> +dnl Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org> dnl Copyright © 2014 Mark H Weaver <mhw@netris.org> dnl dnl This file is part of GNU Guix. @@ -162,3 +162,59 @@ AC_DEFUN([GUIX_CHECK_UNBUFFERED_CBIP], [ ac_cv_guix_cbips_support_setvbuf=no fi]) ]) + +dnl GUIX_TEST_ROOT_DIRECTORY +AC_DEFUN([GUIX_TEST_ROOT_DIRECTORY], [ + AC_CACHE_CHECK([for unit test root directory], + [ac_cv_guix_test_root], + [ac_cv_guix_test_root="`pwd`/test-tmp"]) +]) + +dnl 'BINPRM_BUF_SIZE' constant in Linux. The Hurd has a limit +dnl of about a page (see exec/hashexec.c.) +m4_define([LINUX_HASH_BANG_LIMIT], 128) + +dnl Hardcoded 'sun_path' length in <sys/un.h>. +m4_define([SOCKET_FILE_NAME_LIMIT], 108) + +dnl GUIX_SOCKET_FILE_NAME_LENGTH +AC_DEFUN([GUIX_SOCKET_FILE_NAME_LENGTH], [ + AC_CACHE_CHECK([the length of the installed socket file name], + [ac_cv_guix_socket_file_name_length], + [ac_cv_guix_socket_file_name_length="`echo -n "$guix_localstatedir/guix/daemon-socket/socket" | wc -c`"]) +]) + +dnl GUIX_TEST_SOCKET_FILE_NAME_LENGTH +AC_DEFUN([GUIX_TEST_SOCKET_FILE_NAME_LENGTH], [ + AC_REQUIRE([GUIX_TEST_ROOT_DIRECTORY]) + AC_CACHE_CHECK([the length of the socket file name used in tests], + [ac_cv_guix_test_socket_file_name_length], + [ac_cv_guix_test_socket_file_name_length="`echo -n "$ac_cv_guix_test_root/var/123456/daemon-socket/socket" | wc -c`"]) +]) + +dnl GUIX_HASH_BANG_LENGTH +AC_DEFUN([GUIX_HASH_BANG_LENGTH], [ + AC_CACHE_CHECK([the length of a typical hash bang line], + [ac_cv_guix_hash_bang_length], + [ac_cv_guix_hash_bang_length=`echo -n "$storedir/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bootstrap-binaries-0/bin/bash" | wc -c`]) +]) + +dnl GUIX_CHECK_FILE_NAME_LIMITS +dnl +dnl GNU/Linux has a couple of silly limits that we can easily run into. +dnl Make sure everything is fine with the current settings. +AC_DEFUN([GUIX_CHECK_FILE_NAME_LIMITS], [ + AC_REQUIRE([GUIX_SOCKET_FILE_NAME_LENGTH]) + AC_REQUIRE([GUIX_TEST_SOCKET_FILE_NAME_LENGTH]) + AC_REQUIRE([GUIX_HASH_BANG_LENGTH]) + + if test "$ac_cv_guix_socket_file_name_length" -ge ]SOCKET_FILE_NAME_LIMIT[; then + AC_MSG_ERROR([socket file name would exceed the maxium allowed length]) + fi + if test "$ac_cv_guix_test_socket_file_name_length" -ge ]SOCKET_FILE_NAME_LIMIT[; then + AC_MSG_WARN([socket file name limit may be exceeded when running tests]) + fi + if test "$ac_cv_guix_hash_bang_length" -ge ]LINUX_HASH_BANG_LIMIT[; then + AC_MSG_ERROR([store directory '$storedir' would lead to overly long hash-bang lines]) + fi +]) |