From 407175a1d0e29f45639e7f28a531b3981cd20085 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Mon, 9 Jan 2023 16:48:01 +0100 Subject: daemon: Improve error message for wrong hash sizes. * nix/libutil/hash.cc (parseHash): Show the hash algorithm name and expected size in the error message. * tests/derivations.scm ("fixed-output derivation, invalid hash size"): New test. --- tests/derivations.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'tests') diff --git a/tests/derivations.scm b/tests/derivations.scm index 3d25365b14..66c777cfe7 100644 --- a/tests/derivations.scm +++ b/tests/derivations.scm @@ -396,6 +396,18 @@ (define prefix-len (string-length dir)) (call-with-input-file p get-bytevector-all)) (bytevector? (query-path-hash %store p))))))) +(test-assert "fixed-output derivation, invalid hash size" + (guard (c ((store-protocol-error? c) + (string-contains-ci (store-protocol-error-message c) + "invalid SHA512 hash"))) + (derivation %store "download-with-invalid-hash" + "builtin:download" '() + #:env-vars `(("url" + . ,(object->string "http://example.org"))) + #:hash-algo 'sha512 + #:hash #vu8(1 2 3)) + #f)) + (test-assert "derivation with a fixed-output input" ;; A derivation D using a fixed-output derivation F doesn't has the same ;; output path when passed F or F', as long as F and F' have the same output -- cgit v1.2.3