From dec3e015eb22844539e95a1cf55eedb22e56a55d Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Wed, 24 Feb 2016 09:18:14 +0200 Subject: gnu: dropbear: Update to 2015.71. * gnu/packages/ssh.scm (dropbear): Update to 2015.71. --- gnu/packages/ssh.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'gnu/packages/ssh.scm') diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm index d4bf29cc20..41cb38134f 100644 --- a/gnu/packages/ssh.scm +++ b/gnu/packages/ssh.scm @@ -1,7 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2013, 2014 Andreas Enge ;;; Copyright © 2014, 2015, 2016 Mark H Weaver -;;; Copyright © 2015 Efraim Flashner +;;; Copyright © 2015, 2016 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -332,14 +332,15 @@ (define-public mosh (define-public dropbear (package (name "dropbear") - (version "2014.63") + (version "2015.71") (source (origin (method url-fetch) (uri (string-append - "http://matt.ucc.asn.au/" name "/releases/" + "https://matt.ucc.asn.au/" name "/releases/" name "-" version ".tar.bz2")) (sha256 - (base32 "1bjpbg2vi5f332q4bqxkidkjfxsqmnqvp4g1wyh8d99b8gg94nar")))) + (base32 + "1bw3lzmisn6gs6zy9vcqbfnicl437ydskqcayklpw60fkhb18qip")))) (build-system gnu-build-system) (arguments `(#:tests? #f)) ; There is no "make check" or anything similar (inputs `(("zlib" ,zlib))) -- cgit v1.2.3 From 78d80c5c6ae971a715f03465030d3b0de24a1a96 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Wed, 24 Feb 2016 15:57:30 -0500 Subject: gnu: libssh2: Update to 1.7.0 [fixes CVE-2016-0787]. * gnu/packages/ssh.scm (libssh2): Update to 1.7.0. (libssh2-1.4): New variable. * gnu/packages/curl.scm (curl)[inputs]: Use libssh4-1.4. Modified-By: Mark H Weaver --- gnu/packages/curl.scm | 11 ++++++++++- gnu/packages/ssh.scm | 28 ++++++++++++++++++++++++---- 2 files changed, 34 insertions(+), 5 deletions(-) (limited to 'gnu/packages/ssh.scm') diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 222910b655..46e0fa0f16 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -54,7 +54,16 @@ (define-public curl (inputs `(("gnutls" ,gnutls) ("gss" ,gss) ("libidn" ,libidn) - ("libssh2" ,libssh2) + + ;; XXX libssh2-1.4 is a temporary package for use only by curl, + ;; to allow most users of libssh2 to get the security update for + ;; CVE-2016-7087 while postponing the large number of rebuilds + ;; entailed by updating curl. Soon, curl should be updated to + ;; use the latest libssh2 and libssh2-1.4 should be removed. + + ;; XXX libssh2-1.4 is vulnerable to CVE-2016-0787. + ("libssh2" ,libssh2-1.4) + ("openldap" ,openldap) ("zlib" ,zlib))) (native-inputs diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm index 41cb38134f..f70dcd1b52 100644 --- a/gnu/packages/ssh.scm +++ b/gnu/packages/ssh.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2013, 2014 Andreas Enge ;;; Copyright © 2014, 2015, 2016 Mark H Weaver ;;; Copyright © 2015, 2016 Efraim Flashner +;;; Copyright © 2016 Leo Famulari ;;; ;;; This file is part of GNU Guix. ;;; @@ -85,14 +86,15 @@ (define libssh-0.5 ; kept private (define-public libssh2 (package (name "libssh2") - (version "1.4.3") + (version "1.7.0") (source (origin (method url-fetch) (uri (string-append - "http://www.libssh2.org/download/libssh2-" + "https://www.libssh2.org/download/libssh2-" version ".tar.gz")) - (sha256 (base32 - "0vdr478dbhbdgnniqmirawjb7mrcxckn4slhhrijxnzrkmgziipa")))) + (sha256 + (base32 + "116mh112w48vv9k3f15ggp5kxw5sj4b88dzb5j69llsh7ba1ymp4")))) (build-system gnu-build-system) ;; The installed libssh2.pc file does not include paths to libgcrypt and ;; zlib libraries, so we need to propagate the inputs. @@ -108,6 +110,24 @@ (define-public libssh2 (license license:bsd-3) (home-page "http://www.libssh2.org/"))) +;;; XXX This is a temporary package for use only by curl, to allow most users +;;; of libssh2 to get the security update sooner while postponing the large +;;; number of rebuilds entailed by updating curl. +;;; +;;; XXX This package is vulnerable to CVE-2016-7087. +;;; +;;; https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2016-0787 +(define-public libssh2-1.4 + (package (inherit libssh2) + (version "1.4.3") + (source (origin + (method url-fetch) + (uri (string-append "https://www.libssh2.org/download/libssh2-" + version ".tar.gz")) + (sha256 + (base32 + "0vdr478dbhbdgnniqmirawjb7mrcxckn4slhhrijxnzrkmgziipa")))))) + (define-public openssh (package (name "openssh") -- cgit v1.2.3 From 85267efb2ab6d274d6193928efaee10f97895134 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Wed, 24 Feb 2016 15:57:31 -0500 Subject: gnu: libssh: Update to 0.7.3 [fixes CVE-2016-0739]. * gnu/packages/patches/libssh-CVE-2014-0017.patch: Delete file. * gnu/packages/patches/libssh-0.6.5-CVE-2016-0739.patch: New file. * gnu-system.am (dist_patch_DATA): Adjust accordingly. * gnu/packages/ssh.scm (libssh): Update to 0.7.3. (libssh-0.5): Rename to... (libssh-0.6): ... this. Update to 0.6.5. [source]: Add patch for CVE-2016-0739. (guile-ssh)[inputs]: Use libssh-0.6. Modified-By: Mark H Weaver --- gnu-system.am | 2 +- .../patches/libssh-0.6.5-CVE-2016-0739.patch | 77 +++++++++++++++++++ gnu/packages/patches/libssh-CVE-2014-0017.patch | 89 ---------------------- gnu/packages/ssh.scm | 22 +++--- 4 files changed, 90 insertions(+), 100 deletions(-) create mode 100644 gnu/packages/patches/libssh-0.6.5-CVE-2016-0739.patch delete mode 100644 gnu/packages/patches/libssh-CVE-2014-0017.patch (limited to 'gnu/packages/ssh.scm') diff --git a/gnu-system.am b/gnu-system.am index a93b005c17..9788228cc4 100644 --- a/gnu-system.am +++ b/gnu-system.am @@ -566,12 +566,12 @@ dist_patch_DATA = \ gnu/packages/patches/libmad-armv7-thumb-pt2.patch \ gnu/packages/patches/libmad-frame-length.patch \ gnu/packages/patches/libmad-mips-newgcc.patch \ + gnu/packages/patches/libssh-0.6.5-CVE-2016-0739.patch \ gnu/packages/patches/libtheora-config-guess.patch \ gnu/packages/patches/libtiff-CVE-2015-8665+CVE-2015-8683.patch \ gnu/packages/patches/libtiff-oob-accesses-in-decode.patch \ gnu/packages/patches/libtiff-oob-write-in-nextdecode.patch \ gnu/packages/patches/libtool-skip-tests2.patch \ - gnu/packages/patches/libssh-CVE-2014-0017.patch \ gnu/packages/patches/libunwind-CVE-2015-3239.patch \ gnu/packages/patches/libwmf-CAN-2004-0941.patch \ gnu/packages/patches/libwmf-CVE-2006-3376.patch \ diff --git a/gnu/packages/patches/libssh-0.6.5-CVE-2016-0739.patch b/gnu/packages/patches/libssh-0.6.5-CVE-2016-0739.patch new file mode 100644 index 0000000000..a5fdd7ffff --- /dev/null +++ b/gnu/packages/patches/libssh-0.6.5-CVE-2016-0739.patch @@ -0,0 +1,77 @@ +Fix CVE-2016-0739 (Weak Diffie-Hellman secret generation in +dh_generate_x() and dh_generate_y()). + +"Due to a byte/bit confusion, the DH secret was too short. This file was +completely reworked and will be commited in a future version." +Source: +https://git.libssh.org/projects/libssh.git/commit/?id=f8d0026c65fc8a55748ae481758e2cf376c26c86 + +This patch was created by upstream for libssh-0.7.3, but applied without +modification to libssh-0.6.3 by Debian. In Guix, we apply it without +modification to libssh-0.6.5. + +References: +https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2016-0739 +https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-0739 +https://security-tracker.debian.org/tracker/CVE-2016-0739 + +--- + src/dh.c | 22 +++++++++++++++++----- + 1 file changed, 17 insertions(+), 5 deletions(-) + +diff --git a/src/dh.c b/src/dh.c +index e489a1d..d27b66e 100644 +--- a/src/dh.c ++++ b/src/dh.c +@@ -227,15 +227,21 @@ void ssh_crypto_finalize(void) { + } + + int dh_generate_x(ssh_session session) { ++ int keysize; ++ if (session->next_crypto->kex_type == SSH_KEX_DH_GROUP1_SHA1) { ++ keysize = 1023; ++ } else { ++ keysize = 2047; ++ } + session->next_crypto->x = bignum_new(); + if (session->next_crypto->x == NULL) { + return -1; + } + + #ifdef HAVE_LIBGCRYPT +- bignum_rand(session->next_crypto->x, 128); ++ bignum_rand(session->next_crypto->x, keysize); + #elif defined HAVE_LIBCRYPTO +- bignum_rand(session->next_crypto->x, 128, 0, -1); ++ bignum_rand(session->next_crypto->x, keysize, -1, 0); + #endif + + /* not harder than this */ +@@ -248,15 +254,21 @@ int dh_generate_x(ssh_session session) { + + /* used by server */ + int dh_generate_y(ssh_session session) { +- session->next_crypto->y = bignum_new(); ++ int keysize; ++ if (session->next_crypto->kex_type == SSH_KEX_DH_GROUP1_SHA1) { ++ keysize = 1023; ++ } else { ++ keysize = 2047; ++ } ++ session->next_crypto->y = bignum_new(); + if (session->next_crypto->y == NULL) { + return -1; + } + + #ifdef HAVE_LIBGCRYPT +- bignum_rand(session->next_crypto->y, 128); ++ bignum_rand(session->next_crypto->y, keysize); + #elif defined HAVE_LIBCRYPTO +- bignum_rand(session->next_crypto->y, 128, 0, -1); ++ bignum_rand(session->next_crypto->y, keysize, -1, 0); + #endif + + /* not harder than this */ +-- +cgit v0.12 + diff --git a/gnu/packages/patches/libssh-CVE-2014-0017.patch b/gnu/packages/patches/libssh-CVE-2014-0017.patch deleted file mode 100644 index 94d8cc33d2..0000000000 --- a/gnu/packages/patches/libssh-CVE-2014-0017.patch +++ /dev/null @@ -1,89 +0,0 @@ -Patch from libssh 0.6, with bind.c hunk adjusted for 0.5.5. - -From e99246246b4061f7e71463f8806b9dcad65affa0 Mon Sep 17 00:00:00 2001 -From: Aris Adamantiadis -Date: Wed, 05 Feb 2014 20:24:12 +0000 -Subject: security: fix for vulnerability CVE-2014-0017 - -When accepting a new connection, a forking server based on libssh forks -and the child process handles the request. The RAND_bytes() function of -openssl doesn't reset its state after the fork, but simply adds the -current process id (getpid) to the PRNG state, which is not guaranteed -to be unique. -This can cause several children to end up with same PRNG state which is -a security issue. ---- -diff --git a/include/libssh/wrapper.h b/include/libssh/wrapper.h -index 7374a88..e8ff32c 100644 ---- a/include/libssh/wrapper.h -+++ b/include/libssh/wrapper.h -@@ -70,5 +70,6 @@ int crypt_set_algorithms_server(ssh_session session); - struct ssh_crypto_struct *crypto_new(void); - void crypto_free(struct ssh_crypto_struct *crypto); - -+void ssh_reseed(void); - - #endif /* WRAPPER_H_ */ -diff --git a/src/bind.c b/src/bind.c -index 8d82d0d..03d3403 100644 ---- a/src/bind.c -+++ b/src/bind.c -@@ -375,6 +375,8 @@ int ssh_bind_accept(ssh_bind sshbind, ss - session->dsa_key = dsa; - session->rsa_key = rsa; - -+ /* force PRNG to change state in case we fork after ssh_bind_accept */ -+ ssh_reseed(); - return SSH_OK; - } - -diff --git a/src/libcrypto.c b/src/libcrypto.c -index bb1d96a..d8cc795 100644 ---- a/src/libcrypto.c -+++ b/src/libcrypto.c -@@ -23,6 +23,7 @@ - #include - #include - #include -+#include - - #include "libssh/priv.h" - #include "libssh/session.h" -@@ -38,6 +39,8 @@ - #include - #include - #include -+#include -+ - #ifdef HAVE_OPENSSL_AES_H - #define HAS_AES - #include -@@ -74,6 +77,12 @@ static int alloc_key(struct ssh_cipher_struct *cipher) { - return 0; - } - -+void ssh_reseed(void){ -+ struct timeval tv; -+ gettimeofday(&tv, NULL); -+ RAND_add(&tv, sizeof(tv), 0.0); -+} -+ - SHACTX sha1_init(void) { - SHACTX c = malloc(sizeof(*c)); - if (c == NULL) { -diff --git a/src/libgcrypt.c b/src/libgcrypt.c -index 899bccd..4617901 100644 ---- a/src/libgcrypt.c -+++ b/src/libgcrypt.c -@@ -45,6 +45,9 @@ static int alloc_key(struct ssh_cipher_struct *cipher) { - return 0; - } - -+void ssh_reseed(void){ -+ } -+ - SHACTX sha1_init(void) { - SHACTX ctx = NULL; - gcry_md_open(&ctx, GCRY_MD_SHA1, 0); --- -cgit v0.9.1 diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm index f70dcd1b52..3c73e47882 100644 --- a/gnu/packages/ssh.scm +++ b/gnu/packages/ssh.scm @@ -45,15 +45,15 @@ (define-module (gnu packages ssh) (define-public libssh (package (name "libssh") - (version "0.6.5") + (version "0.7.3") (source (origin (method url-fetch) (uri (string-append - "https://red.libssh.org/attachments/download/121/libssh-" + "https://red.libssh.org/attachments/download/195/libssh-" version ".tar.xz")) (sha256 (base32 - "0b6wyx6bwbb8jpn8x4rhlrdiqwqrwrs0mxjmrnqykm9kw1ijgm8g")))) + "165g49i4kmm3bfsjm0n8hm21kadv79g9yjqyq09138jxanz4dvr6")))) (build-system cmake-build-system) (arguments '(#:configure-flags '("-DWITH_GCRYPT=ON") @@ -71,17 +71,19 @@ (define-public libssh (home-page "http://www.libssh.org") (license license:lgpl2.1+))) -(define libssh-0.5 ; kept private +(define libssh-0.6 ; kept private for use in guile-ssh (package (inherit libssh) - (version "0.5.5") + (version "0.6.5") (source (origin (method url-fetch) - (uri (string-append "https://red.libssh.org/attachments/download/51/libssh-" - version ".tar.gz")) + (uri (string-append "https://red.libssh.org/attachments/" + "download/121/libssh-" + version ".tar.xz")) (sha256 (base32 - "17cfdff4hc0ijzrr15biq29fiabafz0bw621zlkbwbc1zh2hzpy0")) - (patches (list (search-patch "libssh-CVE-2014-0017.patch"))))))) + "0b6wyx6bwbb8jpn8x4rhlrdiqwqrwrs0mxjmrnqykm9kw1ijgm8g")) + (patches (list + (search-patch "libssh-0.6.5-CVE-2016-0739.patch"))))))) (define-public libssh2 (package @@ -255,7 +257,7 @@ (define-public guile-ssh ("pkg-config" ,pkg-config) ("which" ,which))) (inputs `(("guile" ,guile-2.0) - ("libssh" ,libssh) + ("libssh" ,libssh-0.6) ("libgcrypt" ,libgcrypt))) (synopsis "Guile bindings to libssh") (description -- cgit v1.2.3 From b35461748b20d0172744974b39e7d9d033400c51 Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Sat, 27 Feb 2016 08:37:28 -0500 Subject: gnu: Fix misplaced commas (unquote). Fix many occurrences of comma (unquote) being placed immediately after the previous list item, e.g. ("ncurses", ncurses) in the inputs. * gnu/packages/base.scm (patch, gnu-make), gnu/packages/bioinformatics.scm (hmmer), gnu/packages/bittorrent.scm (aria2), gnu/packages/compression.scm (pbzip2), gnu/packages/databases.scm (recutils), gnu/packages/fonts.scm (font-terminus), gnu/packages/freedesktop.scm (xdg-utils, elogind), gnu/packages/games.scm (gnujump), gnu/packages/gnome.scm (libidl, gnumeric, eog, gedit), gnu/packages/gnunet.scm (gnunet), gnu/packages/gnuzilla.scm (mozjs, nspr), gnu/packages/gtk.scm (gtksourceview, gdk-pixbuf), gnu/packages/lua.scm (lua), gnu/packages/openstack.scm (python-swiftclient), gnu/packages/perl.scm (perl-json-any), gnu/packages/polkit.scm (polkit-qt), gnu/packages/python.scm (wrap-python3, python-oauthlib) (python-mccabe-0.2.1, python-contextlib2, python2-rauth), gnu/packages/qt.scm (qtkeychain), gnu/packages/ruby.scm (ruby-nokogiri), gnu/packages/screen.scm (screen), gnu/packages/ssh.scm (libssh), gnu/packages/video.scm (ffmpeg, mplayer), gnu/packages/vim.scm (vim), gnu/packages/xdisorg.scm (redshift), gnu/packages/xfce.scm (xfce4-panel, xfce4-settings), gnu/packages/xnee.scm (xnee), gnu/packages/xorg.scm (font-adobe100dpi, font-adobe75dpi), gnu/packages/zsh.scm (zsh): Fix misplaced commas (unquote). --- gnu/packages/base.scm | 4 ++-- gnu/packages/bioinformatics.scm | 2 +- gnu/packages/bittorrent.scm | 2 +- gnu/packages/compression.scm | 2 +- gnu/packages/databases.scm | 2 +- gnu/packages/fonts.scm | 2 +- gnu/packages/freedesktop.scm | 4 ++-- gnu/packages/games.scm | 2 +- gnu/packages/gnome.scm | 8 ++++---- gnu/packages/gnunet.scm | 2 +- gnu/packages/gnuzilla.scm | 4 ++-- gnu/packages/gtk.scm | 4 ++-- gnu/packages/lua.scm | 2 +- gnu/packages/openstack.scm | 2 +- gnu/packages/perl.scm | 6 +++--- gnu/packages/polkit.scm | 2 +- gnu/packages/python.scm | 12 ++++++------ gnu/packages/qt.scm | 2 +- gnu/packages/ruby.scm | 2 +- gnu/packages/screen.scm | 2 +- gnu/packages/ssh.scm | 2 +- gnu/packages/video.scm | 8 ++++---- gnu/packages/vim.scm | 8 ++++---- gnu/packages/xdisorg.scm | 2 +- gnu/packages/xfce.scm | 4 ++-- gnu/packages/xnee.scm | 2 +- gnu/packages/xorg.scm | 4 ++-- gnu/packages/zsh.scm | 8 ++++---- 28 files changed, 53 insertions(+), 53 deletions(-) (limited to 'gnu/packages/ssh.scm') diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index 7cef8bf24a..e6628277a6 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -173,7 +173,7 @@ (define-public patch "16d2r9kpivaak948mxzc0bai45mqfw73m113wrkmbffnalv1b5gx")) (patches (list (search-patch "patch-hurd-path-max.patch"))))) (build-system gnu-build-system) - (native-inputs `(("ed", ed))) + (native-inputs `(("ed" ,ed))) (synopsis "Apply differences to originals, with optional backups") (description "Patch is a program that applies changes to files based on differences @@ -327,7 +327,7 @@ (define-public gnu-make "19gwwhik3wdwn0r42b7xcihkbxvjl9r2bdal8nifc3k5i4rn3iqb")) (patches (list (search-patch "make-impure-dirs.patch"))))) (build-system gnu-build-system) - (native-inputs `(("pkg-config", pkg-config))) ; to detect Guile + (native-inputs `(("pkg-config" ,pkg-config))) ; to detect Guile (inputs `(("guile" ,guile-2.0))) (outputs '("out" "debug")) (arguments diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index 8958ec502d..7b3838d36f 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -1790,7 +1790,7 @@ (define-public hmmer (base32 "0djmgc0pfli0jilfx8hql1axhwhqxqb8rxg2r5rg07aw73sfs5nx")))) (build-system gnu-build-system) - (native-inputs `(("perl", perl))) + (native-inputs `(("perl" ,perl))) (home-page "http://hmmer.janelia.org") (synopsis "Biosequence analysis using profile hidden Markov models") (description diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 15b69cf03e..ae67988d71 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -225,7 +225,7 @@ (define-public aria2 (("CPPUNIT_TEST_SUITE_REGISTRATION\\(LpdMessageReceiverTest\\);" text) (string-append "// " text)))))))) (native-inputs - `(("pkg-config", pkg-config))) + `(("pkg-config" ,pkg-config))) (inputs `(("c-ares" ,c-ares) ("cppunit" ,cppunit) ; for the tests diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index 4a31bf79e2..938d4b8718 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -244,7 +244,7 @@ (define-public pbzip2 "1vk6065dv3a47p86vmp8hv3n1ygd9hraz0gq89gvzlx7lmcb6fsp")))) (build-system gnu-build-system) (inputs - `(("bzip2", bzip2))) + `(("bzip2" ,bzip2))) (arguments `(#:tests? #f ; no tests #:phases (modify-phases %standard-phases diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index 7c30208035..25c1e6a7df 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -321,7 +321,7 @@ (define-public recutils (native-inputs `(("emacs" ,emacs-no-x) ("bc" ,bc) ("bash:include" ,bash "include") - ("libuuid", util-linux))) + ("libuuid" ,util-linux))) ;; TODO: Add more optional inputs. (inputs `(("curl" ,curl) diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm index b9cebdc3fb..69e195dbf0 100644 --- a/gnu/packages/fonts.scm +++ b/gnu/packages/fonts.scm @@ -373,7 +373,7 @@ (define-public font-terminus `(("pkg-config" ,pkg-config) ("perl" ,perl) ("bdftopcf" ,bdftopcf) - ("font-util", font-util) + ("font-util" ,font-util) ("mkfontdir" ,mkfontdir))) (arguments `(#:configure-flags (list diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index 6a28379e95..bfe6e4569c 100644 --- a/gnu/packages/freedesktop.scm +++ b/gnu/packages/freedesktop.scm @@ -69,7 +69,7 @@ (define-public xdg-utils (build-system gnu-build-system) (propagated-inputs `(("xprop" ,xprop) ; for Xfce detecting - ("xset", xset))) ; for xdg-screensaver + ("xset" ,xset))) ; for xdg-screensaver (arguments `(#:tests? #f)) ; no check target (home-page "http://portland.freedesktop.org/") @@ -178,7 +178,7 @@ (define-public elogind ("xsltproc" ,libxslt) ("m4" ,m4) ("libxml2" ,libxml2) ;for XML_CATALOG_FILES - ("pkg-config", pkg-config) + ("pkg-config" ,pkg-config) ("gperf" ,gperf))) (inputs `(("linux-pam" ,linux-pam) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 8a0b395b85..991fa24697 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -997,7 +997,7 @@ (define-public gnujump (lambda _ (setenv "LIBS" "-lm")))))) (inputs `(("glu" ,glu) - ("mesa", mesa) + ("mesa" ,mesa) ("sdl" ,sdl) ("sdl-image" ,sdl-image) ("sdl-mixer" ,sdl-mixer))) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 578b43121b..0960b534f1 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -941,7 +941,7 @@ (define-public libidl (inputs `(("glib" ,glib))) (native-inputs `(("pkg-config" ,pkg-config) - ("flex", flex) + ("flex" ,flex) ("bison" ,bison))) (home-page "http://freecode.com/projects/libidl") (synopsis "Create trees of CORBA Interface Definition Language files") @@ -1585,7 +1585,7 @@ (define-public gnumeric ("libxml2" ,libxml2) ("libxslt" ,libxslt) ("python" ,python-2) - ("python2-pygobject", python2-pygobject-2) + ("python2-pygobject" ,python2-pygobject-2) ("zlib" ,zlib))) (native-inputs `(("intltool" ,intltool) @@ -3230,7 +3230,7 @@ (define-public eog `(("dconf" ,dconf))) (native-inputs `(("intltool" ,intltool) - ("itstool", itstool) + ("itstool" ,itstool) ("glib" ,glib "bin") ("gobject-introspection" ,gobject-introspection) ("pkg-config" ,pkg-config) @@ -3881,7 +3881,7 @@ (define-public gedit `(("dconf" ,dconf))) (native-inputs `(("intltool" ,intltool) - ("itstool", itstool) + ("itstool" ,itstool) ("gobject-introspection" ,gobject-introspection) ("pkg-config" ,pkg-config))) (inputs diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm index e3f64ef324..eb0c4cbe83 100644 --- a/gnu/packages/gnunet.scm +++ b/gnu/packages/gnunet.scm @@ -224,7 +224,7 @@ (define-public gnunet ("libunistring" ,libunistring) ("openssl" ,openssl) ("opus" ,opus) - ("pulseaudio", pulseaudio) + ("pulseaudio" ,pulseaudio) ("sqlite" ,sqlite) ("zlib" ,zlib))) (native-inputs diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 1d3ebe8c8e..dca461f5d4 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -72,7 +72,7 @@ (define-public mozjs (("defined\\(@TEMPLATE_FILE)") "@TEMPLATE_FILE"))))) (build-system gnu-build-system) (native-inputs - `(("perl", perl) + `(("perl" ,perl) ("python" ,python-2))) (arguments `(#:phases @@ -154,7 +154,7 @@ (define-public nspr "01ria9wk6329hxqsy75p9dkxiqkq4nkz0jjzll7hslih3jbi8dil")))) (build-system gnu-build-system) (native-inputs - `(("perl", perl))) + `(("perl" ,perl))) (arguments `(#:tests? #f ; no check target #:configure-flags (list "--enable-64bit" diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index 452906a5a1..1a10e9b551 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -365,7 +365,7 @@ (define-public gtksourceview (native-inputs `(("glib:bin" ,glib "bin") ; for glib-genmarshal, etc. ("intltool" ,intltool) - ("itstool", itstool) + ("itstool" ,itstool) ("gobject-introspection" ,gobject-introspection) ("pkg-config" ,pkg-config) ("vala" ,vala) @@ -425,7 +425,7 @@ (define-public gdk-pixbuf (native-inputs `(("pkg-config" ,pkg-config) ("glib" ,glib "bin") ; glib-mkenums, etc. - ("gobject-introspection", gobject-introspection))) ; g-ir-compiler, etc. + ("gobject-introspection" ,gobject-introspection))) ; g-ir-compiler, etc. (synopsis "GNOME image loading and manipulation library") (description "GdkPixbuf is a library for image loading and manipulation developed diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm index d27c024cfb..fcb41831eb 100644 --- a/gnu/packages/lua.scm +++ b/gnu/packages/lua.scm @@ -40,7 +40,7 @@ (define-public lua (patches (list (search-patch "lua-pkgconfig.patch") (search-patch "lua52-liblua-so.patch"))))) (build-system gnu-build-system) - (inputs `(("readline", readline))) + (inputs `(("readline" ,readline))) (arguments '(#:modules ((guix build gnu-build-system) (guix build utils) diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm index 08a76a3695..0fa488f842 100644 --- a/gnu/packages/openstack.scm +++ b/gnu/packages/openstack.scm @@ -770,7 +770,7 @@ (define-public python-swiftclient "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p")))) (build-system python-build-system) (native-inputs - `(("python-pbr", python-pbr) + `(("python-pbr" ,python-pbr) ("python-setuptools" ,python-setuptools) ("python-sphinx" ,python-sphinx) ;; The folloing packages are needed for the tests. diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 0c0b8a3e87..6ca62aa2ae 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -2758,9 +2758,9 @@ (define-public perl-json-any (build-system perl-build-system) (native-inputs `(("perl-test-fatal" ,perl-test-fatal) - ("perl-test-requires", perl-test-requires) - ("perl-test-warnings", perl-test-warnings) - ("perl-test-without-module", perl-test-without-module))) + ("perl-test-requires" ,perl-test-requires) + ("perl-test-warnings" ,perl-test-warnings) + ("perl-test-without-module" ,perl-test-without-module))) (propagated-inputs `(("perl-namespace-clean" ,perl-namespace-clean))) (home-page "http://search.cpan.org/dist/JSON-Any") diff --git a/gnu/packages/polkit.scm b/gnu/packages/polkit.scm index 0a4f70f734..4f21612804 100644 --- a/gnu/packages/polkit.scm +++ b/gnu/packages/polkit.scm @@ -144,7 +144,7 @@ (define-public polkit-qt (propagated-inputs `(("qt" ,qt))) ; qt-4 according to the pkg-config files (native-inputs - `(("pkg-config", pkg-config))) + `(("pkg-config" ,pkg-config))) (arguments `(#:configure-flags (list (string-append "-DCMAKE_INSTALL_RPATH=" (assoc-ref %outputs "out") diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index b67aed05f7..2441220901 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -332,8 +332,8 @@ (define* (wrap-python3 python (lambda (old new) (symlink (string-append python old) (string-append bin "/" new))) - `("python3", "pydoc3", "idle3") - `("python", "pydoc", "idle")))))) + `("python3" ,"pydoc3" ,"idle3") + `("python" ,"pydoc" ,"idle")))))) (synopsis "Wrapper for the Python 3 commands") (description "This package provides wrappers for the commands of Python@tie{}3.x such @@ -2347,7 +2347,7 @@ (define-public python-oauthlib (build-system python-build-system) (native-inputs `(("python-setuptools" ,python-setuptools) - ("python-coverage", python-coverage) + ("python-coverage" ,python-coverage) ("python-nose" ,python-nose) ("python-mock" ,python-mock))) (inputs @@ -5142,7 +5142,7 @@ (define-public python-mccabe-0.2.1 (sha256 (base32 "0fi4a81kr5bcv5p4xgibqr595hyj5dafkqgsmfk96mfy8w71fajs")))) - (inputs `(("python-setuptools", python-setuptools))))) + (inputs `(("python-setuptools" ,python-setuptools))))) (define-public python2-mccabe-0.2.1 (package-with-python2 python-mccabe-0.2.1)) @@ -6753,7 +6753,7 @@ (define-public python-contextlib2 (replace 'check (lambda _ (zero? (system* - "python" "test_contextlib2.py", "-v"))))))) + "python" "test_contextlib2.py" "-v"))))))) (home-page "http://contextlib2.readthedocs.org/") (synopsis "Tools for decorators and context managers") (description "This module is primarily a backport of the Python @@ -7247,7 +7247,7 @@ (define-public python2-rauth (package (inherit rauth) (propagated-inputs `(("python2-requests" ,python2-requests))) (native-inputs - `(("python2-unittest2", python2-unittest2) + `(("python2-unittest2" ,python2-unittest2) ,@(package-native-inputs rauth)))))) (define-public python2-functools32 diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 363596d0fd..bfd99b6519 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -555,7 +555,7 @@ (define-public qtkeychain (base32 "055mkd4pz6cyff4cw0784wjc1w92m8x223sxi96ph15fr3lplbg6")))) (build-system cmake-build-system) (inputs - `(("qt", qt))) + `(("qt" ,qt))) (arguments `(#:tests? #f ; No tests included #:phases diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index fa7c2f7691..a1669d4238 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -1905,7 +1905,7 @@ (define-public ruby-nokogiri "/include/libxml2" )))) (native-inputs `(("ruby-hoe" ,ruby-hoe) - ("ruby-rake-compiler", ruby-rake-compiler))) + ("ruby-rake-compiler" ,ruby-rake-compiler))) (inputs `(("zlib" ,zlib) ("libxml2" ,libxml2) diff --git a/gnu/packages/screen.scm b/gnu/packages/screen.scm index fa5235c115..088ca559d8 100644 --- a/gnu/packages/screen.scm +++ b/gnu/packages/screen.scm @@ -44,7 +44,7 @@ (define-public screen (native-inputs `(("makeinfo" ,texinfo))) (inputs - `(("ncurses", ncurses) + `(("ncurses" ,ncurses) ("perl" ,perl))) (arguments `(#:configure-flags diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm index 3c73e47882..081c7cbe32 100644 --- a/gnu/packages/ssh.scm +++ b/gnu/packages/ssh.scm @@ -61,7 +61,7 @@ (define-public libssh ;; TODO: Add 'CMockery' and '-DWITH_TESTING=ON' for the test suite. #:tests? #f)) (inputs `(("zlib" ,zlib) - ("libgcrypt", libgcrypt))) + ("libgcrypt" ,libgcrypt))) (synopsis "SSH client library") (description "libssh is a C library implementing the SSHv2 and SSHv1 protocol for diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 865d0e3fba..7d6c363da8 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -406,7 +406,7 @@ (define-public ffmpeg ("speex" ,speex) ("twolame" ,twolame) ("xvid" ,xvid) - ("zlib", zlib))) + ("zlib" ,zlib))) (native-inputs `(("bc" ,bc) ("perl" ,perl) @@ -620,14 +620,14 @@ (define-public mplayer (inputs `(("alsa-lib" ,alsa-lib) ("cdparanoia" ,cdparanoia) - ("ffmpeg", ffmpeg) + ("ffmpeg" ,ffmpeg) ("fontconfig" ,fontconfig) ("freetype" ,freetype) ;; ("giflib" ,giflib) ; uses QuantizeBuffer, requires version >= 5 ("lame" ,lame) ("libass" ,libass) - ("libdvdcss", libdvdcss) - ("libdvdnav", libdvdnav) + ("libdvdcss" ,libdvdcss) + ("libdvdnav" ,libdvdnav) ("libjpeg" ,libjpeg) ("libmpeg2" ,libmpeg2) ("libmpg123" ,mpg123) ; audio codec for MP3 diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm index e117fc4dff..241896323c 100644 --- a/gnu/packages/vim.scm +++ b/gnu/packages/vim.scm @@ -53,10 +53,10 @@ (define-public vim (("/bin/sh") (which "sh")))) %standard-phases))) (inputs - `(("gawk", gawk) - ("inetutils", inetutils) - ("ncurses", ncurses) - ("perl", perl) + `(("gawk" ,gawk) + ("inetutils" ,inetutils) + ("ncurses" ,ncurses) + ("perl" ,perl) ("tcsh" ,tcsh))) ; For runtime/tools/vim32 (home-page "http://www.vim.org/") (synopsis "Text editor based on vi") diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm index f01e17a23f..d72f9f80c6 100644 --- a/gnu/packages/xdisorg.scm +++ b/gnu/packages/xdisorg.scm @@ -701,7 +701,7 @@ (define-public redshift `(("libdrm" ,libdrm) ("libx11" ,libx11) ("libxcb" ,libxcb) - ("libxxf86vm", libxxf86vm) + ("libxxf86vm" ,libxxf86vm) ("glib" ,glib))) ;for Geoclue2 support (home-page "https://github.com/jonls/redshift") (synopsis "Adjust the color temperature of your screen") diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index 7fab65043b..2aef842d5a 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -282,7 +282,7 @@ (define-public xfce4-panel `(("libxfce4util" ,libxfce4util))) ; required by libxfce4panel-1.0.pc (inputs `(("exo" ,exo) - ("garcon", garcon) + ("garcon" ,garcon) ("libwnck" ,libwnck-1) ("libxfce4ui" ,libxfce4ui))) (native-search-paths @@ -519,7 +519,7 @@ (define-public xfce4-settings `(("exo" ,exo) ("garcon" ,garcon) ("libnotify" ,libnotify) - ("libxcursor", libxcursor) + ("libxcursor" ,libxcursor) ("libxi" ,libxi) ("libxklavier" ,libxklavier) ("libxrandr" ,libxrandr) diff --git a/gnu/packages/xnee.scm b/gnu/packages/xnee.scm index 4e9135dd5b..84dd85b2e7 100644 --- a/gnu/packages/xnee.scm +++ b/gnu/packages/xnee.scm @@ -39,7 +39,7 @@ (define-public xnee "04n2lac0vgpv8zsn7nmb50hf3qb56pmj90dmwnivg09gyrf1x92j")))) (build-system gnu-build-system) (inputs - `(("gtk+", gtk+-2) + `(("gtk+" ,gtk+-2) ("inputproto" ,inputproto) ("libx11" ,libx11) ("libxext" ,libxext) diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm index 9f7b726c53..f69661d088 100644 --- a/gnu/packages/xorg.scm +++ b/gnu/packages/xorg.scm @@ -348,7 +348,7 @@ (define-public font-adobe100dpi (build-system gnu-build-system) (inputs `(("bdftopcf" ,bdftopcf) - ("font-util", font-util) + ("font-util" ,font-util) ("mkfontdir" ,mkfontdir))) (native-inputs `(("pkg-config" ,pkg-config))) @@ -380,7 +380,7 @@ (define-public font-adobe75dpi (build-system gnu-build-system) (inputs `(("bdftopcf" ,bdftopcf) - ("font-util", font-util) + ("font-util" ,font-util) ("mkfontdir" ,mkfontdir))) (native-inputs `(("pkg-config" ,pkg-config))) diff --git a/gnu/packages/zsh.scm b/gnu/packages/zsh.scm index 6d25fd4671..fba7bb19b8 100644 --- a/gnu/packages/zsh.scm +++ b/gnu/packages/zsh.scm @@ -64,10 +64,10 @@ (define-public zsh "Util/preconfig") (("/bin/sh") (which "sh"))))) %standard-phases))) - (native-inputs `(("autoconf", autoconf))) - (inputs `(("ncurses", ncurses) - ("pcre", pcre) - ("perl", perl))) + (native-inputs `(("autoconf" ,autoconf))) + (inputs `(("ncurses" ,ncurses) + ("pcre" ,pcre) + ("perl" ,perl))) (synopsis "Powerful shell for interactive use and scripting") (description "The Z shell (zsh) is a Unix shell that can be used as an interactive login shell and as a powerful command interpreter -- cgit v1.2.3