From 4e6df8040e539e4635420eef1a2a26af209b614d Mon Sep 17 00:00:00 2001 From: Reepca Russelstein Date: Fri, 25 Oct 2024 01:04:48 -0500 Subject: activation: Create directory with specified perms in ‘mkdir-p/perms’. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is currently a window of time between when the desired directory is created and when its permissions are changed. During this time, its permissions are restricted only by the umask. Of course, in the "directory already exists" case, this doesn't matter, but if the directory has been specifically deleted ahead of time so that it is created afresh, this is an unnecessary window. We can avoid this by passing the caller-provided BITS to 'mkdirat' when attempting to create the last directory. * gnu/build/activation.scm (mkdir-p/perms): Create target directory with BITS permissions. Change-Id: I03d2c620872e86b6f591abe0f1c8317aa1245383 Signed-off-by: Ludovic Courtès --- gnu/build/activation.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/build/activation.scm b/gnu/build/activation.scm index d1a2876a96..a450578c24 100644 --- a/gnu/build/activation.scm +++ b/gnu/build/activation.scm @@ -113,7 +113,9 @@ (define open-flags (logior O_CLOEXEC ; don't pass the port on to subprocesses ;; If not, create it. (catch 'system-error (lambda _ - (mkdirat root head)) + (if (null? tail) + (mkdirat root head bits) + (mkdirat root head))) (lambda args ;; Someone else created the directory. Unexpected but fine. (unless (= EEXIST (system-error-errno args)) -- cgit v1.2.3