From 704f1496451e380c356a90d85e614277025c1ef4 Mon Sep 17 00:00:00 2001 From: Christopher Baines Date: Sat, 18 Jan 2020 10:18:17 +0000 Subject: Improve the compare-invalid-parameters messages --- guix-data-service/web/compare/html.scm | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) (limited to 'guix-data-service') diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm index f493714..c96967a 100644 --- a/guix-data-service/web/compare/html.scm +++ b/guix-data-service/web/compare/html.scm @@ -970,16 +970,26 @@ (div (@ (class "container")) (h1 "Unknown commit") ,(if (invalid-query-parameter? base-commit) - `(p "No known revision with commit " - (strong (samp ,(invalid-query-parameter-value base-commit))) - ,(if (null? base-job) - " and it is not currently queued for processing" - " but it is queued for processing")) + (if (null? base-job) + `(p "No known revision with commit " + (strong (samp ,(invalid-query-parameter-value base-commit))) + ".") + `(p "Revision " + (a (@ (href + ,(string-append "/revision/" + (invalid-query-parameter-value base-commit)))) + (strong (samp ,(invalid-query-parameter-value base-commit)))) + " is queued for processing.")) '()) ,(if (invalid-query-parameter? target-commit) - `(p "No known revision with commit " - (strong (samp ,(invalid-query-parameter-value target-commit))) - ,(if (null? target-job) - " and it is not currently queued for processing" - " but it is queued for processing")) + (if (null? target-job) + `(p "No known revision with commit " + (strong (samp ,(invalid-query-parameter-value target-commit))) + ".") + `(p "Revision " + (a (@ (href + ,(string-append "/revision/" + (invalid-query-parameter-value target-commit)))) + (strong (samp ,(invalid-query-parameter-value target-commit)))) + " is queued for processing.")) '()))))) -- cgit v1.2.3