From acc2dab7f2f50c9169d6388007c770878eae4a9c Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Mon, 30 Oct 2017 11:23:46 -0500 Subject: gnu: Disable gnulib's test-lock test in packages. * gnu/packages/base.scm (findutils)[source]: Disable test-lock. * gnu/packages/gettext.scm (gettext-minimal)[source]: Ditto. * gnu/packages/libidn.scm (libidn)[source]: Ditto. * gnu/packages/libunistring.scm (libunistring)[source]: Ditto. * gnu/packages/augeas.scm (augeas)[source]: Ditto. * gnu/packages/gsasl.scm (gsasl)[source]: Ditto. * gnu/packages/patches/findutils-gnulib-multi-core.patch, gnu/packages/patches/gettext-gnulib-multi-core.patch, gnu/packages/patches/gettext-multi-core.patch, gnu/packages/patches/libunistring-gnulib-multi-core.patch: Delete patches. * gnu/local.mk (DIST_PATCH_DATA): Remove them. --- gnu/packages/gettext.scm | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) (limited to 'gnu/packages/gettext.scm') diff --git a/gnu/packages/gettext.scm b/gnu/packages/gettext.scm index 76c01b1e09..51b772a586 100644 --- a/gnu/packages/gettext.scm +++ b/gnu/packages/gettext.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2016 Alex Kost ;;; Copyright © 2017 Marius Bakke ;;; Copyright © 2017 Mathieu Othacehe +;;; Copyright © 2017 Eric Bavier ;;; ;;; This file is part of GNU Guix. ;;; @@ -47,12 +48,18 @@ (sha256 (base32 "0hsw28f9q9xaggjlsdp2qmbp2rbd1mp0njzan2ld9kiqwkq2m57z")) - ;; test-lock has performance issues on multi-core machines, - ;; it hangs or takes a long time to complete. - ;; There is one commit in gettext and one commit - ;; in gettext's embedded gnulib to fix this issue. - (patches (search-patches "gettext-multi-core.patch" - "gettext-gnulib-multi-core.patch")))) + (modules '((guix build utils))) + (snippet + '(begin + ;; The gnulib test-lock test is prone to writer starvation + ;; with our glibc@2.25, which prefers readers, so disable it. + ;; The gnulib commit b20e8afb0b2 should fix this once + ;; incorporated here. + (substitute* "gettext-runtime/tests/Makefile.in" + (("TESTS = test-lock\\$\\(EXEEXT\\)") "TESTS =")) + (substitute* "gettext-tools/gnulib-tests/Makefile.in" + (("test-lock\\$\\(EXEEXT\\) ") "")) + #t)))) (build-system gnu-build-system) (outputs '("out" "doc")) ;8 MiB of HTML -- cgit v1.2.3