aboutsummaryrefslogtreecommitdiff
path: root/guix/scripts
diff options
context:
space:
mode:
author宋文武 <iyzsong@member.fsf.org>2017-10-14 22:45:55 +0800
committer宋文武 <iyzsong@member.fsf.org>2017-10-17 19:00:35 +0800
commit5efa0e4d4f25485dcf3c520f9f3db9ef126efdf6 (patch)
treeff67a95573f96a05674685ce564a4e7b7a2e06ad /guix/scripts
parentbb4b9f7bf3d3c465823cd6d261c92fa90f9f97aa (diff)
downloadgnu-guix-5efa0e4d4f25485dcf3c520f9f3db9ef126efdf6.tar
gnu-guix-5efa0e4d4f25485dcf3c520f9f3db9ef126efdf6.tar.gz
guix: substitute: Report the last progress in the child process.
Fixes <https://bugs.gnu.org/28756>. * guix/utils.scm (filtered-port): Close the 'input' port for the current process, and close it upon exit in the child process. * guix/scripts/substitute.scm (progress-substitution): Display "\n\n" after the reporter has finished.
Diffstat (limited to 'guix/scripts')
-rwxr-xr-xguix/scripts/substitute.scm11
1 files changed, 7 insertions, 4 deletions
diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index 921a7c6790..60dbdb1766 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -956,19 +956,22 @@ DESTINATION as a nar file. Verify the substitute against ACL."
#:abbreviation nar-uri-abbreviation)))
(progress-report-port reporter raw)))
((input pids)
+ ;; NOTE: This 'progress' port of current process will be
+ ;; closed here, while the child process doing the
+ ;; reporting will close it upon exit.
(decompressed-port (and=> (narinfo-compression narinfo)
string->symbol)
progress)))
;; Unpack the Nar at INPUT into DESTINATION.
(restore-file input destination)
(close-port input)
- (close-port progress)
+
+ ;; Wait for the reporter to finish.
+ (every (compose zero? cdr waitpid) pids)
;; Skip a line after what 'progress-reporter/file' printed, and another
;; one to visually separate substitutions.
- (display "\n\n" (current-error-port))
-
- (every (compose zero? cdr waitpid) pids))))
+ (display "\n\n" (current-error-port)))))
;;;