diff options
| author | Jonathan Ballet <jon@multani.info> | 2018-02-24 18:24:05 +0100 |
|---|---|---|
| committer | Flavio Castelli <flavio@castelli.me> | 2018-03-05 21:33:33 +0100 |
| commit | d37e941778af77694f63306d4cae3250885abd87 (patch) | |
| tree | 7120d5260bdadbd0b86ea1142e6feaa032d8a2ad | |
| parent | f2cef405133f73155f4085f50f6b5dd6ce38d11a (diff) | |
| download | terraform-provider-libvirt-d37e941778af77694f63306d4cae3250885abd87.tar terraform-provider-libvirt-d37e941778af77694f63306d4cae3250885abd87.tar.gz | |
Fix broken tests due to incorrect usage of t.Skip()
Current tests were broken with the following error:
# github.com/dmacvicar/terraform-provider-libvirt/libvirt
libvirt/resource_libvirt_domain_test.go:874: Skip call has possible formatting directive %s
libvirt/resource_libvirt_domain_test.go:882: Skip call has possible formatting directive %s
FAIL github.com/dmacvicar/terraform-provider-libvirt/libvirt [build failed]
t.Skip with formatting should be t.Skipf()
| -rw-r--r-- | libvirt/resource_libvirt_domain_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libvirt/resource_libvirt_domain_test.go b/libvirt/resource_libvirt_domain_test.go index 78677617..f4332a15 100644 --- a/libvirt/resource_libvirt_domain_test.go +++ b/libvirt/resource_libvirt_domain_test.go @@ -871,7 +871,7 @@ func TestAccLibvirtDomainFirmware(t *testing.T) { if _, err := os.Stat(firmware); os.IsNotExist(err) { firmware = "/usr/share/ovmf/OVMF.fd" if _, err := os.Stat(firmware); os.IsNotExist(err) { - t.Skip("Can't test domain custom firmware: OVMF firmware not found: %s") + t.Skipf("Can't test domain custom firmware: OVMF firmware not found: %s", err) } } @@ -879,7 +879,7 @@ func TestAccLibvirtDomainFirmware(t *testing.T) { if _, err := os.Stat(template); os.IsNotExist(err) { template = "/usr/share/qemu/OVMF.fd" if _, err := os.Stat(template); os.IsNotExist(err) { - t.Skip("Can't test domain custom firmware template: OVMF template not found: %s") + t.Skipf("Can't test domain custom firmware template: OVMF template not found: %s", err) } } |