diff options
| author | Stephen Finucane <stephen.finucane@intel.com> | 2016-03-21 16:31:11 +0000 |
|---|---|---|
| committer | Stephen Finucane <stephen.finucane@intel.com> | 2016-03-25 11:25:10 +0000 |
| commit | e8750a4741401a5574c2c980783cecc743f94c4a (patch) | |
| tree | ef2c6c6bf0535fd66b90cb1bd69d091628857520 /templates | |
| parent | aa7e252bf6aac95350bdf50b02e82651f82f5bf7 (diff) | |
| download | patchwork-e8750a4741401a5574c2c980783cecc743f94c4a.tar patchwork-e8750a4741401a5574c2c980783cecc743f94c4a.tar.gz | |
views: Use messages framework in 'patch'
Django provides the messages framework as part of the core library.
This framework allows for "toast"-style notifications to the user,
for things like post-form processing notifcations. At the moment
patchwork provides this functionality using custom code. However, this
code is not well tested and, like any code, incurs some degree of
maintenance overhead. It would be easier to use the "batteries" that
Django provides so begin doing just that.
This change only covers one of two places in which this custom
messages framework is currently used. By extension, it also covers one
of the two places in which 'render_to_response' is still used. This
"other place" will be addressed in a follow-up commit.
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Tested-by: Andy Doan <andy.doan@linaro.org>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/base.html | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/templates/base.html b/templates/base.html index 0e9dd0f..8521edf 100644 --- a/templates/base.html +++ b/templates/base.html @@ -101,6 +101,8 @@ {% if messages %} <div id="messages"> {% for message in messages %} + {# TODO(stephenfin): Make use of message.tags when completely #} + {# converted to django.contrib.messages #} <div class="message">{{ message }}</div> {% endfor %} </div> |